win,msi: fix documentation shortcut url #2781
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #2779. |
mscdex
force-pushed
the
fix-win-docs-shortcut
branch
from
3f73b92
to
4b0439c
Compare
mscdex
added
windows
mscdex
changed the title
mscdex
force-pushed
the
fix-win-docs-shortcut
branch
from
4b0439c
to
0ff3c6d
Compare
|
This is not the correct fix, the correct one is simply to change: i.e. It's intended to work for all release types, not just general releases but also nightlies, release candidates etc. |
|
^ the history of this error is that io.js always shipped with "doc" matching the name of the dir in the repo but node.js shipped with "docs" and we've moved to the latter for both now, the msi changes went in to io.js pre merge |
mscdex
force-pushed
the
fix-win-docs-shortcut
branch
from
0ff3c6d
to
adb54b0
Compare
|
Updated. |
|
lgtm |
mscdex
added a commit
that referenced
this pull request
Sep 10, 2015
Fixes: #2779 PR-URL: #2781 Reviewed-By: Rod Vagg <[email protected]>
|
Landed in 81a0c0b. |
mscdex
added a commit
that referenced
this pull request
Sep 11, 2015
Fixes: #2779 PR-URL: #2781 Reviewed-By: Rod Vagg <[email protected]>
mscdex
added a commit
that referenced
this pull request
Sep 12, 2015
Fixes: #2779 PR-URL: #2781 Reviewed-By: Rod Vagg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.